You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We had a customer not too long ago inform us that pushDown didn't work when specifying top as the position of a barlayout modal. Upon some testing and digging I've confirmed that when using top we get the console error from line 471 in the method above... and upon checking some of the code, found the function referenced above. It looks like the function is looking for either top-fixed or top-absolute, where our Pathfora docs (http://lytics.github.io/pathforadocs/layouts/bar/#pushdown) reference the top-absolute as simply top. So the check is failing.
I think we need to either or both:
Adjust the function to allow for top
Adjust our documentation to specify top-absolute
The text was updated successfully, but these errors were encountered:
pathforajs/dist/pathfora.js
Line 467 in 0094f38
We had a customer not too long ago inform us that pushDown didn't work when specifying
top
as theposition
of abar
layout
modal. Upon some testing and digging I've confirmed that when usingtop
we get the console error from line 471 in the method above... and upon checking some of the code, found the function referenced above. It looks like the function is looking for eithertop-fixed
ortop-absolute
, where our Pathfora docs (http://lytics.github.io/pathforadocs/layouts/bar/#pushdown) reference thetop-absolute
as simplytop
. So the check is failing.I think we need to either or both:
Adjust the function to allow for
top
Adjust our documentation to specify
top-absolute
The text was updated successfully, but these errors were encountered: