Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Modal loading twice with exclude scaffolding #636

Open
ashyablok opened this issue Dec 13, 2023 · 0 comments
Open

Single Modal loading twice with exclude scaffolding #636

ashyablok opened this issue Dec 13, 2023 · 0 comments
Labels

Comments

@ashyablok
Copy link
Contributor

Related: https://github.com/lytics/lytics-ui/issues/2082

We ran into a scenario where a single modal was loading twice. Causing the following error in the console:

image

For context, the account had both experiences and legacy personalize campaigns. There were domains set in the orchestrate allowlist, but the domain in question was not in that list, thus personalize campaigns were loading. There was one active campaign that was loading, but it wasn't even set to display on the domain in question. The config had both the target and exclude set in the scaffolding, which resulted in the following in the config:

w.pathfora.utils.insertWidget("target","all",pfa_111,widgetConfig)
w.pathfora.utils.insertWidget("exclude","111_conversion",pfa_111,widgetConfig)

Testing this locally did not result in an error, but when loaded by the config.js by the jstag it caused the console error.

We believe it has something to do with the exclude render code:
https://github.com/lytics/pathforajs/blob/develop/src/rollup/widgets/init-targeted-widgets.js#L34-L62

@ashyablok ashyablok added the bug label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant