Make uid label configurable #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Feb 4, 2019
m0n9oose
requested changes
Feb 4, 2019
iconoeugen
force-pushed
the
feature/configurable_uid_label
branch
from
a33cda6 to
6d08609
Compare
ghost
reviewed
Feb 7, 2019
iconoeugen
force-pushed
the
feature/configurable_uid_label
branch
from
6d08609 to
2f73c9e
Compare
ghost
reviewed
Feb 7, 2019
m0n9oose
requested changes
Feb 7, 2019
iconoeugen
force-pushed
the
feature/configurable_uid_label
branch
2 times, most recently
from
25c7846 to
19ce2cc
Compare
ghost
reviewed
Feb 7, 2019
iconoeugen
force-pushed
the
feature/configurable_uid_label
branch
from
19ce2cc to
53d1511
Compare
iconoeugen
force-pushed
the
feature/configurable_uid_label
branch
from
53d1511 to
2bbcaef
Compare
bcarr092
referenced
this pull request
in Zetatango/omniauth_openid_connect
Mar 8, 2019
* upgrade openid_connect dependency * fix mocha deprecation warning * tweak travis settings * Fix tests, update some dependencies * Fix warnings * Allows ui_locales, claims_locales and login_hint as request params Ref: [http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest](http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest) These params are allowed to be used during Authentication request. * forward `params` call to `request.params` * RP-Initiated Logout phase (#5) * Add logout phase * Avoid to make a discover for each other_phase call * avoid using match when MatchData is not used * Make uid label configurable (#11) * add partner option * fix: Gracefully handle state mismatch (#6)
miguelakira
referenced
this pull request
in Zetatango/omniauth_openid_connect
May 8, 2019
* upgrade openid_connect dependency * fix mocha deprecation warning * tweak travis settings * Fix tests, update some dependencies * Fix warnings * Allows ui_locales, claims_locales and login_hint as request params Ref: [http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest](http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest) These params are allowed to be used during Authentication request. * forward `params` call to `request.params` * RP-Initiated Logout phase (#5) * Add logout phase * Avoid to make a discover for each other_phase call * avoid using match when MatchData is not used * Make uid label configurable (#11) * add partner option * fix: Gracefully handle state mismatch (#6)
miguelakira
referenced
this pull request
in Zetatango/omniauth_openid_connect
May 8, 2019
miguelakira
referenced
this pull request
in Zetatango/omniauth_openid_connect
May 8, 2019
* upgrade openid_connect dependency * fix mocha deprecation warning * tweak travis settings * Fix tests, update some dependencies * Fix warnings * Allows ui_locales, claims_locales and login_hint as request params Ref: [http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest](http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest) These params are allowed to be used during Authentication request. * forward `params` call to `request.params` * RP-Initiated Logout phase (#5) * Add logout phase * Avoid to make a discover for each other_phase call * avoid using match when MatchData is not used * Make uid label configurable (#11) * add partner option * fix: Gracefully handle state mismatch (#6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uid is always using the
subvalue from the userinfo, which in some applications is not the expected value.To avoid such limitations, the uid label is now configurable by providing the omniauth
uid_labeloption to a different label (i.e.preferred_username) that appears in the userinfo details.The default value for uid_label is set to sub to ensure the backward compatibility is not broken.