Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use response_mode in authorize_uri if the option is defined #30

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

januszm
Copy link
Contributor

@januszm januszm commented Aug 2, 2019

This resolves: #29

Some OpenID servers are configured to format the request to the client application as a POST request (form_post). This PR allows you to actually use an unused configuration option.

Patchlevel change.

@m0n9oose m0n9oose merged commit ca7e97e into omniauth:master Aug 2, 2019
@m0n9oose
Copy link
Collaborator

m0n9oose commented Aug 3, 2019

@januszm could you please test current master branch one more time before i push this update to the rubygems. This would help a lot to make sure this release is stable.

@januszm januszm deleted the hotfix/use_response_mode_option branch August 3, 2019 10:03
@januszm
Copy link
Contributor Author

januszm commented Aug 3, 2019

@m0n9oose I tested the master branch today, works fine on a dev server. It's not a production, user-facing system yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option response_mode is defined but not used
2 participants