Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't specify pod annotations #136

Closed
brndnmtthws opened this issue May 11, 2019 · 4 comments
Closed

Can't specify pod annotations #136

brndnmtthws opened this issue May 11, 2019 · 4 comments

Comments

@brndnmtthws
Copy link

There's no way to add annotations to m3db pods at the moment. Specifically, I want to add these:

   annotations:
     prometheus.io/scrape: "true"
     prometheus.io/port: "7203"

Ideally it could be part of the cluster spec.

@schallert
Copy link
Collaborator

Sounds like a great idea! Happy to add this

@robskillington
Copy link
Collaborator

robskillington commented Jun 19, 2019

@brndnmtthws I added a PR for this, taken a bit to get to but here it is #155.

@brndnmtthws
Copy link
Author

@brndnmtthws I added a PR for this, taken a bit to get to but here it is #155.

Sweet! I'm busy with other things, but I'll revisit m3db later.

@robskillington
Copy link
Collaborator

Closed with #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants