Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Session Custom Attributes #25

Merged
merged 1 commit into from
Apr 19, 2023
Merged

feat: Add Session Custom Attributes #25

merged 1 commit into from
Apr 19, 2023

Conversation

BrandonStalnaker
Copy link
Contributor

Instructions

  1. PR target branch should be against main
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add session level custom attributes and unit test

Testing Plan

  • Locally tested and unit tested

Reference Issue

@BrandonStalnaker BrandonStalnaker self-assigned this Apr 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

einsteinx2
einsteinx2 approved these changes Apr 19, 2023
View reviewed changes
Copy link

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 653d8ad into main Apr 19, 2023
@BrandonStalnaker BrandonStalnaker deleted the feat/SQDSDKS-5230-Add-Session-Custom-Attributes branch April 19, 2023 17:07
mparticle-automation added a commit that referenced this pull request May 22, 2023
@mparticle-automation
chore: 1.5.0 (release)
9a358c1 
## [1.5.0](v1.4.3...v1.5.0) (2023-05-22)

### Features

* Add Session Custom Attributes ([#25](#25)) ([653d8ad](653d8ad))

### Updates & Maintenance

* bump com.android.library from 7.4.1 to 7.4.2 ([#21](#21)) ([8316dc2](8316dc2))
* bump org.jlleitschuh.gradle.ktlint from 11.2.0 to 11.3.1 ([#22](#22)) ([a91250f](a91250f))
* bump org.jlleitschuh.gradle.ktlint from 11.3.1 to 11.3.2 ([#27](#27)) ([03ae09f](03ae09f))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@markvdouw markvdouw Awaiting requested review from markvdouw

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrandonStalnaker @mparticle-automation @einsteinx2