Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearfix output should use double colon notation #68

Open
pdincubus opened this issue Apr 16, 2018 · 2 comments
Open

Clearfix output should use double colon notation #68

pdincubus opened this issue Apr 16, 2018 · 2 comments

Comments

@pdincubus
Copy link

The output for the native Clearfix outputs a :after which should be ::after as per CSS3 spec.

Browser support is IE9+, FF 3.5+, Edge, Safari and Chrome so should not cause issues for anyone supporting current browser usage. Maybe needs an 'Old IE' fallback option to output the :after version too to give choice?
@pdincubus
Copy link
Author

I've made the change to the postcss-clearfix repo and made a pull request.

@madeleineostoja
Copy link
Owner

Yep that was done because postcss-clearfix used to have a legacy option, but it was removed a few versions ago. Happy to merge that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdincubus @madeleineostoja