Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We allow other companies to override our standards #1

Open
antdking opened this issue Oct 23, 2018 · 3 comments
Open

We allow other companies to override our standards #1

antdking opened this issue Oct 23, 2018 · 3 comments

Comments

@antdking
Copy link
Contributor

big one might be rubocop rules

@booyaa
Copy link
Contributor

booyaa commented Oct 31, 2018

Examples:

@antdking
Copy link
Contributor Author

antdking commented Oct 31, 2018

It might be worth encouraging others to use standard approaches to overriding rules:
https://rubocop.readthedocs.io/en/latest/configuration/#inheritance

This has the advantage of being able to be used by editors, and has less of a learning curve (only have to know rubocop, not other tools).

@davidwinter
Copy link
Contributor

I think this needs to be explicitly defined as overridden by another companies established code style guide (Gov.UK being a great example), so that it can't be misinterpreted as just overriding in the code sense that they use # rubocop disable...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants