Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building static library in VIsual Studio 2017 #404

Closed
irwir opened this issue Feb 9, 2019 · 3 comments
Closed

Building static library in VIsual Studio 2017 #404

irwir opened this issue Feb 9, 2019 · 3 comments

Comments

@irwir
Copy link

irwir commented Feb 9, 2019

develop branch.

The solution from vc14 was successfully upgraded, but static library could not be built for x86 and x64 platforms. The diagnostics depended on the selected configuration/platform:

c1 : fatal error C1083: Cannot open source file: '....\masmx64\inffas8664.c': No such file or directory

or

crc32.c
d:\e\tmp\d\tmp\zlib-develop\crc32.c(969): error C2708: 'crc32_combine64': actual parameters length in bytes differs from previous call or reference
d:\e\tmp\d\tmp\zlib-develop\crc32.c(952): note: see declaration of 'crc32_combine64'
d:\e\tmp\d\tmp\zlib-develop\crc32.c(986): error C2708: 'crc32_combine_gen64': actual parameters length in bytes differs from previous call or reference
d:\e\tmp\d\tmp\zlib-develop\crc32.c(973): note: see declaration of 'crc32_combine_gen64'
d:\e\tmp\d\tmp\zlib-develop\crc32.c(990): error C2373: 'crc32_combine_op': redefinition; different type modifiers
d:\e\tmp\d\tmp\zlib-develop\zlib.h(1767): note: see declaration of 'crc32_combine_op'

Solutions for eariler versions of Visual Studio could have similar issues (vc12 does), and vc15 and vc16 solutions might be added to the existing list.

@kaoh
Copy link

kaoh commented Apr 26, 2022

@irwir I have created a pull request for VS 22. You can give it a try.

@Neustradamus
Copy link

@irwir: Have you tried?

@madler
Copy link
Owner

madler commented Oct 12, 2022

See d0704a8

@madler madler closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants