Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Project Wildcard Exclusion #23

Open
jeffdoolittle opened this issue Jun 21, 2022 · 8 comments
Open

[FEATURE] Project Wildcard Exclusion #23

jeffdoolittle opened this issue Jun 21, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@jeffdoolittle
Copy link
Contributor

It would be nice to generate diagrams that exclude folders/projects with a given wildcard parameter, such as:

  • **/*.Tests
  • **/*.Tests.csproj

This would enable a much simpler and cleaner view in repositories where the test projects live next to their implementations, rather than in a separate tests folder with a different project root.

@jeffdoolittle jeffdoolittle added the enhancement New feature or request label Jun 21, 2022
@madushans
Copy link
Owner

Yep this is a good idea.
Likely can use the (somewhat) new File Globbing package.

We should be able to use the existing parameters and still make it backwards compatible.

@jeffdoolittle jeffdoolittle changed the title Project Wildcard Exclusion [FEATURE] Project Wildcard Exclusion Jun 21, 2022
@jeffdoolittle
Copy link
Contributor Author

Ok, I'm working on PR right now.

@jeffdoolittle
Copy link
Contributor Author

@madushans PR is ready for your review.

#24

@madushans
Copy link
Owner

Hey sorry I'm away for a few days.. will have a look soon.

@EdToro74
Copy link

Can this feature be merged into the main branch? It's a great feature and at a quick glance the PR seems good to go.

@madushans
Copy link
Owner

hey @EdToro74 @jeffdoolittle
I've been away for a bit. I'll merge this soon along with a few other features and fixes to get a new version out. I think many of the similar requests to filter the output is better done in the frontend.

It seems like the most popular feature is getting the graph, which is really under-developed right now. So I'll focus more on building a more featured frontend, and eventually move this functionality there.

@madushans
Copy link
Owner

Looks like the exclusion is disregarded in the curernt PR, since it continues with the directory search regardless, after looking up project files.

I'm planning this feature for the front end piece anyway. So I'll do it there later.

@EdToro74
Copy link

Thanks for the quick reply, I've worked around the issue by just scripting out all the excludes. Looking forward to the integration when you get there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants