Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RunVWith command #261

Merged
merged 4 commits into from
Oct 3, 2019
Merged

Conversation

eberkund
Copy link
Contributor

Resolves #260

@eberkund
Copy link
Contributor Author

The failing CI is due to an unrelated issue I believe.

@natefinch
Copy link
Member

Well that's interesting. It's probably a bug in tip of some sort. I'll take a look.

Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's call this RunWithV, and then I'm right there with you

sh/cmd.go Outdated Show resolved Hide resolved
sh/cmd.go Outdated Show resolved Hide resolved
eberkund and others added 2 commits September 12, 2019 16:19
Co-Authored-By: Nate Finch <nate.finch@gmail.com>
Co-Authored-By: Nate Finch <nate.finch@gmail.com>
@eberkund
Copy link
Contributor Author

Done!

@crazy-max
Copy link
Member

@natefinch Really need this feature 😅 Any ETA?

Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@natefinch natefinch merged commit 9e2b3db into magefile:master Oct 3, 2019
mojzesh pushed a commit to mojzesh/mage that referenced this pull request Oct 12, 2019
mojzesh pushed a commit to mojzesh/mage that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RunVWith
3 participants