Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -ldflags flag #322

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Add -ldflags flag #322

merged 1 commit into from
Nov 19, 2020

Conversation

tukeJonny
Copy link
Contributor

Resolve #320 .

@tukeJonny tukeJonny mentioned this pull request Nov 4, 2020
Closed
@tukeJonny
Copy link
Contributor Author

@natefinch

Travis is running, but from what I've seen of travis's builds, the build seems to be a success.

@tukeJonny
Copy link
Contributor Author

@natefinch

Sorry for notifying you many times .

Let me know if there is anything that I can resolve that is hindering the review.

As a known issue, the Travis results are not being picked up by Github, but this seems to be more due to Travis than a code issue.

natefinch
natefinch approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you! I'll poke travis tonight just to double check the build, but then I can merge it.

@tukeJonny
Copy link
Contributor Author

@natefinch

Thank you!
Then, is it likely to be double check in Travis?

@natefinch
Copy link
Member

Travis is kind of messed up right now... but this ran and passed, so I'll call it good.
https://travis-ci.com/github/magefile/mage/builds/202629089

@natefinch natefinch merged commit 2ded30c into magefile:master Nov 19, 2020
@tukeJonny tukeJonny deleted the add-ldflags-flag-for-compile branch November 21, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natefinch natefinch natefinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When compiling mage statically, cannot pass ldflags
2 participants
@tukeJonny @natefinch