fix: deterministic compiled mainfile #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sort template data so resulting mainfile is consistantly reproducible, which is important to leverage build cache and results in a consistent build id on output (given identical build parameters, e.g. ldflags, output file name, etc.) Result of `mage -compile ./mage_static && go tool buildid ./mage_static` should now always be identical on repeated invocation. Results in a probably imperceptible build time quickening, but solves a minor peave of mine, and adds a test as protection from regression :)
natefinch
reviewed
May 18, 2021
Co-authored-by: Nate Finch <nate.finch@gmail.com>
ClaudiaJ
changed the title
paulburlumi
reviewed
Jul 6, 2021
got caught out not using vim's spellcheck Co-authored-by: Paul Burlumi <paul@burlumi.com>
got caught out not using vim's spellcheck Co-authored-by: Paul Burlumi <paul@burlumi.com>
mirogta
reviewed
Sep 24, 2021
mirogta
previously approved these changes
Sep 24, 2021
There was a problem hiding this comment.
@natefinch LGTM too after the changes :-)
(just looking at PR's and issues to help with after seeing your msg to make this group-owned)
|
Lemme check this tonight and I can probably merge it. |
Co-authored-by: Paul Burlumi <paul@burlumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort template data so resulting mainfile is consistantly reproducible,
which is important to leverage build cache and results in a consistent
build id on output (given identical build parameters, e.g. sorted ldflags, etc.)
Result of
mage -compile ./mage_static && go tool buildid ./mage_staticshould now always be identical on repeated invocation.
Results in a probably imperceptible build time quickening, but solves a
minor peave of mine, and adds a test as protection from regression :)
also a couple minor formatting fixes from gopls courtesy of format on save.