Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of GIF XMP writing to MediaGalleryMetadat module implementation #1552

Closed
sivaschenko opened this issue Jul 2, 2020 · 1 comment · Fixed by #1570
Closed

Add support of GIF XMP writing to MediaGalleryMetadat module implementation #1552

sivaschenko opened this issue Jul 2, 2020 · 1 comment · Fixed by #1570
Assignees
@Nazar65
Labels
Backend Complex Priority: P2 Should be fixed as early as possible
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

Add support of GIF XMP writing to MediaGalleryMetadat module implementation.

Technical Design:
https://github.com/magento/adobe-stock-integration/wiki/Technical-Design:-Images-metadata-processing

What needs to be done:

  • Introduce Magento\MediaGalleryMetadata\Model\Gif\FileWriter class (see examples of implementation in Png and Jpeg namespaces)
  • Introduce Magento\MediaGalleryMetadata\Model\Jpeg\Segment\XmpWriter(see examples of implementation in Png and Jpeg namespaces)
  • Extend Magento\MediaGalleryMetadata\Test\Integration\Model\AddMetadataTest data provider with a test using gif image
@m2-assistant
Copy link

m2-assistant bot commented Jul 2, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko added this to the 2.1.0 milestone Jul 2, 2020
@sivaschenko sivaschenko added Priority: P1 Needs to be fixed before any other issues Complex Priority: P2 Should be fixed as early as possible and removed Priority: P1 Needs to be fixed before any other issues labels Jul 2, 2020
@Nazar65 Nazar65 self-assigned this Jul 8, 2020
@Nazar65 Nazar65 mentioned this issue Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nazar65 Nazar65

Labels
Backend Complex Priority: P2 Should be fixed as early as possible
Projects
None yet
Milestone
2.1.0
2 participants
@sivaschenko @Nazar65