Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Refactor phtml templates #1642

Closed
sivaschenko opened this issue Jul 24, 2020 · 2 comments
Closed

[Refactoring] Refactor phtml templates #1642

sivaschenko opened this issue Jul 24, 2020 · 2 comments
Assignees
@joweecaquicla
Labels
Progress: done
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

#1612

Description (*)

Related to #1578

As per code review we need to avoid the use of legacy syntax. More info can be found here https://devdocs.magento.com/guides/v2.4/ui_comp_guide/concepts/magento-bindings.html

Files to refactor:

  • MediaGalleryUi/view/adminhtml/templates/image_details.phtml:30
  • MediaGalleryUi/view/adminhtml/templates/image_details_standalone.phtml:28
  • MediaGalleryUi/view/adminhtml/templates/image_edit_details.phtml:28
  • MediaGalleryUi/view/adminhtml/templates/image_edit_details_standalone.phtml:34
@m2-assistant
Copy link

m2-assistant bot commented Jul 24, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@lenaorobei lenaorobei added this to the 2.1.0 milestone Jul 24, 2020
@joweecaquicla
Copy link

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joweecaquicla joweecaquicla

Labels
Progress: done
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@sivaschenko @lenaorobei @joweecaquicla