OrderGridCollectionFilter Plugin Breaks Mapping for created_at Column

[sgeleon]

Preconditions and environment

• Magento v2.4.7-p1

Steps to reproduce

STEPS TO REPRODUCE
Sales > Orders
Filters > set Purchase Date from and to
Click Apply Filters

Expected result

The filters are applied.

Actual result

'Something went wrong with processing the default view and we have restored the filter to its original state.

Additional information

This problem is same like from this bug report.

This plugin is fixed it.

Index: vendor/magento/module-sales/Plugin/Model/ResourceModel/Order/OrderGridCollectionFilter.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/vendor/magento/module-sales/Plugin/Model/ResourceModel/Order/OrderGridCollectionFilter.php b/vendor/magento/module-sales/Plugin/Model/ResourceModel/Order/OrderGridCollectionFilter.php
--- a/vendor/magento/module-sales/Plugin/Model/ResourceModel/Order/OrderGridCollectionFilter.php	
+++ b/vendor/magento/module-sales/Plugin/Model/ResourceModel/Order/OrderGridCollectionFilter.php	(date 1717557636000)
@@ -56,7 +56,7 @@
             }
 
             $fieldName = $subject->getConnection()->quoteIdentifier($field);
-            $condition = $subject->getConnection()->prepareSqlCondition($fieldName, $condition);
+            $condition = $subject->getConnection()->prepareSqlCondition('`main_table`.'.$fieldName, $condition);
             $subject->getSelect()->where($condition, null, Select::TYPE_CONDITION);
 
             return $subject;

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @sgeleon. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, here is your Magento Instance: https://2dee4f3e57d1e8b3dcd060f3fc05d923.instances-prod.magento-community.engineering
Admin access: https://2dee4f3e57d1e8b3dcd060f3fc05d923.instances-prod.magento-community.engineering/admin_088d
Login: ffc4092e
Password: f6036bfdcba1

[engcom-Dash]

Hi @sgeleon

Thanks for reporting and collaboration.

Verified the issue on Magento 2.4 dev instance but the issue is not reproducible.

However, we can reproduce the issue on 2.4.7-p1.

The issue might have been fixed in the latest 2.4 dev branch.

Steps to reproduce
STEPS TO REPRODUCE
Sales > Orders
Filters > set Purchase Date from and to
Click Apply Filters

Please refer the attached screen-recording.

In 2.4 dev instance:

38916.mov

In 2.4.7-p1:

[hclauss-ltk]

Hello together,

we have the same issue and can´t filter our products anymore, same error applies. Also since the error occurs, we can´t even see the unfiltered product overview anymore. Are there any updates how to reset this?

Thanks in advance!

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, here is your Magento Instance: https://2dee4f3e57d1e8b3dcd060f3fc05d923.instances-prod.magento-community.engineering
Admin access: https://2dee4f3e57d1e8b3dcd060f3fc05d923.instances-prod.magento-community.engineering/admin_fa25
Login: ccfc4daa
Password: 7bc925ecfd0e

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, here is your Magento Instance: https://2dee4f3e57d1e8b3dcd060f3fc05d923.instances-prod.magento-community.engineering
Admin access: https://2dee4f3e57d1e8b3dcd060f3fc05d923.instances-prod.magento-community.engineering/admin_b6dd
Login: 49787e9a
Password: 7e28d927c3b2

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, here is your Magento Instance: https://2dee4f3e57d1e8b3dcd060f3fc05d923.instances-prod.magento-community.engineering
Admin access: https://2dee4f3e57d1e8b3dcd060f3fc05d923.instances-prod.magento-community.engineering/admin_4262
Login: 82f621ed
Password: 3ddf6a42d3b6

[engcom-Dash]

Hi @sgeleon

We have verified the issue on 2.4 dev instance but the issue is not reproducible.

Please look into the screenshots attached.

Let us know if we missed anything.

Thanks.

[Bashev]

Fixed in #36818, but it's never released.

magento2/app/code/Magento/Sales/Plugin/Model/ResourceModel/Order/OrderGridCollectionFilter.php

Line 58 in 11e7d89

$fieldName = $subject->getConnection()->quoteIdentifier('main_table.' . $field);

@engcom-Dash can you confirm, this will comes with next release?

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[Bashev]

@engcom-Hotel what kind of update is required here? As i mentioned above, PR is merged (f09c222), but somehow is not released in 2.4.7-p2

[engcom-Hotel]

Hello @Bashev,

Thanks for your query!

We have started a discussion internally on your query and will reply you back ASAP on this.

Meanwhile moving this issue on hold.

Thanks

[engcom-Hotel]

Hello @Bashev,

We have just received a reply from the internal team. The fix will be released in the 2.4.8 version.

Thanks

[dchaykas]

@engcom-Hotel will the fix address #39000 as well? If yes, then it can be closed with a comment.