Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Default Currency still have old currencies #6832

Closed
milinka opened this issue Oct 1, 2016 · 9 comments
Closed

Store Default Currency still have old currencies #6832

milinka opened this issue Oct 1, 2016 · 9 comments
Assignees
Labels
bug report Component: Setup Event: dmcdindia good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@milinka
Copy link

milinka commented Oct 1, 2016

Preconditions

  1. Store Default Currency still have old currencies: FIM (Markka).
  2. Magento version 2

Steps to reproduce

  1. Start magento installation
  2. Process to step: Step 4: Customize Your Store
  3. Click to drop down for default currency: FIM (Markka).

Expected result

  1. FIM (Markka) Should be removed. Finland has moved to EUR in 2001

Actual result

  1. [Screenshot, logs]
@dthampy dthampy added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 25, 2016
@dthampy
Copy link
Contributor

dthampy commented Oct 25, 2016

Internal jira -MAGETWO-60033 has been created for this issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Component: Setup labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 9, 2017
@magento-engcom-team
Copy link
Contributor

@milinka, thank you for your report.
We've created internal ticket(s) MAGETWO-60033 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@ArjenMiedema
Copy link

The currencies are loaded from Zend Framework 1, which is not supported anymore by Zend and is currently maintained by Mgento. With the move to PHP 7.2, ZF1 will be removed completely (at least that's what I heard), so it won't be an issue anymore from that moment on.

If this should be solved in older versions of Magento as well, we should go through all files in vendor/magento/zendframework1/library/Zend/Locale/Data/ and remove the old currencies in all these files. It would be a good idea to have a full list of all deprecated currencies then, so we only have to do this once.

However, I'm not sure if this is an issue that requires to be solved. The list of old currencies is not that nice, but it doesn't actually break anything in a webshop. As long as you don't select these currencies, you'd be fine.

@larsroettig
Copy link
Member

I think we should close this issue because of it doesn't actually break anything.

@SubrataBauri
Copy link

I am working on this at #dmcdindia

@magento-engcom-team
Copy link
Contributor

@SubrataBauri thank you for joining. Please accept team invitation here and self-assign the issue.

@magento-engcom-team magento-engcom-team added the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 26, 2018
@ArjenMiedema
Copy link

@SubrataBauri I think that if we remove the deprecated Finnish currency, we should also remove all other deprecated currencies. For example all other European currencies that were used before the Euro are still in this list. Talking about the German Mark, French Franc, Spanish Peseta, etc. These currencies are deprecated since 2002.

I think other currencies have been deprecated in the past decades as well, but I'm not aware which currencies those are. But I think cleaning up this list with more then just one currency is useful. Not sure if you have the time, but it would be great if you can do this.

@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @brunoroeder. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@brunoroeder
Copy link
Contributor

This doesn't actually break anything and the old currencies are loaded from Zend Framework 1, which is not supported anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Setup Event: dmcdindia good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

9 participants