-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Default Currency still have old currencies #6832
Comments
Internal jira -MAGETWO-60033 has been created for this issue. |
@milinka, thank you for your report. |
The currencies are loaded from Zend Framework 1, which is not supported anymore by Zend and is currently maintained by Mgento. With the move to PHP 7.2, ZF1 will be removed completely (at least that's what I heard), so it won't be an issue anymore from that moment on. If this should be solved in older versions of Magento as well, we should go through all files in vendor/magento/zendframework1/library/Zend/Locale/Data/ and remove the old currencies in all these files. It would be a good idea to have a full list of all deprecated currencies then, so we only have to do this once. However, I'm not sure if this is an issue that requires to be solved. The list of old currencies is not that nice, but it doesn't actually break anything in a webshop. As long as you don't select these currencies, you'd be fine. |
I think we should close this issue because of it doesn't actually break anything. |
I am working on this at #dmcdindia |
@SubrataBauri thank you for joining. Please accept team invitation here and self-assign the issue. |
@SubrataBauri I think that if we remove the deprecated Finnish currency, we should also remove all other deprecated currencies. For example all other European currencies that were used before the Euro are still in this list. Talking about the German Mark, French Franc, Spanish Peseta, etc. These currencies are deprecated since 2002. I think other currencies have been deprecated in the past decades as well, but I'm not aware which currencies those are. But I think cleaning up this list with more then just one currency is useful. Not sure if you have the time, but it would be great if you can do this. |
Hi @brunoroeder. Thank you for working on this issue.
|
This doesn't actually break anything and the old currencies are loaded from Zend Framework 1, which is not supported anymore. |
Preconditions
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: