Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product custom options being replaced instead of updated #7875

Closed
bartlubbersen opened this issue Dec 19, 2016 · 3 comments
Closed

Product custom options being replaced instead of updated #7875

bartlubbersen opened this issue Dec 19, 2016 · 3 comments
Assignees
Labels
bug report Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release

Comments

@bartlubbersen
Copy link
Contributor

Preconditions

  1. Magento 2.1.3
  2. PHP7

Steps to reproduce

  1. Create a product with custom options via the API: /V1/products/
  2. The options will apear successfully
  3. Now update the product options while specifying the option_id aswell.

Expected result

  1. The option id should stay the same and the options should be updated rather than being replaced.

Actual result

  1. The option is updated, however the option id changed.

Comment

The reason this can be a problem is because if you have a cart with items inside of it with the custom options specified and you update the product options the current options will be entirely removed because the ID does not exist anymore. Which results in the customer being able to order a product without options. So we would prefer to just update the existing options so this problem won't occur.

@veloraven veloraven added 2.1.x bug report Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog labels Dec 20, 2016
@scottsb
Copy link
Member

scottsb commented Aug 14, 2017

This is a duplicate of #5931. It's deeper than just the REST API.

@magento-engcom-team magento-engcom-team added 2.1.x bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog labels Sep 11, 2017
@sheldmandu
Copy link

@magento-engcom-team Is this resolved given it's a duplicate of #5931 and should hence be closed? What commit was it resolved in? I'm looking to perhaps backport it unless Magento would consider doing it.

@magento-engcom-team
Copy link
Contributor

@bartlubbersen, thank you for your report.
The issue is already fixed in develop branch, 2.2.0

@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Oct 13, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release
Projects
None yet
Development

No branches or pull requests

6 participants