Error shall not be 500 but 403

[krisdante]

Currently, the status code thrown for not accepted IP is:
500 Internal Server Error - Security Exception

It would be better to have a proper HTTP status code like 403 (Frobidden).

Error 500 is reserved for severe server errors - and our monitoring sends alert to DevOps team, and also breaks our statistics about 500 errors.

[krisdante]

Alternatively, it could be also 404 or redirect (temp) to the homepage, so it is not easy to discover what is the admin URL from non-known IPs

[phoenix128]

Maybe 403 is a better option, I agree.

[krisdante]

I submitter the Pull Request. It modifies the LockDown interface in general, but taking into account what this lockdown does - I think it is a good change anyway.
magespecialist/m2-MSP_Security_Suite_Common/pull/3