Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terser to version >= 5.2 / optional chaining problem #136

Open
Yonn-Trimoreau opened this issue Feb 23, 2022 · 4 comments
Open

Upgrade terser to version >= 5.2 / optional chaining problem #136

Yonn-Trimoreau opened this issue Feb 23, 2022 · 4 comments

Comments

@Yonn-Trimoreau
Copy link

Hi,

I use optional chaining pretty heavily in my project (https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Operators/Optional_chaining), and some of the extensions I have installed also make use of this perfectly legal and widely usable syntax (https://caniuse.com/mdn-javascript_operators_optional_chaining).

Terser became compatible with optional chaining as of version 5.2 (terser/terser#567 (comment)), and magepack still uses v4.8 (https://github.com/magesuite/magepack/blob/master/package.json#L24).

I have tried upgrading to the latest version of terser in a forked version (Yonn-Trimoreau@12329e3), and magepack seems to work perfectly fine.

Can you please upgrade?

Thanks in advance,
Best regards

@edward-simpson
Copy link

Any way to expedite this? Optional chaining's been supported by modern browsers for a while now and it's frustrating to not be able to use it without having to pull files out of the bundle

@edward-simpson
Copy link

Created a PR to move this along a bit

@fredden
Copy link
Contributor

fredden commented Aug 26, 2022

It looks like b96eecc upgrades Terser to 5.15.0. I can't find a pull request for that commit though. @Szpadel, this issue can probably be marked as complete when you have released a new version of magepack which includes this commit/change.

@fredden
Copy link
Contributor

fredden commented Oct 28, 2022

This was fixed in version 2.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants