Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo js configs aren't being generated properly #173

Open
toan-tam opened this issue Dec 27, 2022 · 1 comment
Open

Vimeo js configs aren't being generated properly #173

toan-tam opened this issue Dec 27, 2022 · 1 comment

Comments

@toan-tam
Copy link

Hi,

I'm seeing that the Vimeo js files aren't being merged into the bundle files. I belive it's because magepack isn't generating the config properly for Vimeo js files as I'm seeing these lines in the magepack.config.js file.

      'vimeo/player': 'vimeo/player/player',
      'vimeo/vimeo-wrapper': 'vimeo/player/vimeo-wrapper',

I am able to fix this temporarily by removing the player path in the config as below:

      'vimeo/player': 'vimeo/player',
      'vimeo/vimeo-wrapper': 'vimeo/vimeo-wrapper',

I'm using magepack 2.11.2 on Magento Commerce 2.4.5.

Can we get this fixed so that the magepack generate command can collect these Vimeo JS files config properly?

Thanks!

@MaximGns
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants