Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tell please, support 2.4.1 ? #61

Closed
good-geek opened this issue Oct 29, 2020 · 4 comments
Closed

tell please, support 2.4.1 ? #61

good-geek opened this issue Oct 29, 2020 · 4 comments

Comments

@good-geek
Copy link

No description provided.

@delyriand
Copy link

Hi @sarootua,

Do you have a problem with version 2.4.1?
I have tried magepack with this version and have not encountered any issues.

BR.

@jtomaszewski
Copy link
Contributor

BTW question for those who made it work under 2.4.x - is the patch for mixins.js (that the README and this PR magento/baler#23 speaks about) is still needed ? This repo https://github.com/integer-net/magento2-requirejs-bundling says it's not on Magento >= 2.3.6, so curious if I have to do something. (We're running 2.4.1. )

@gaiterjones
Copy link

gaiterjones commented Dec 16, 2020 •
edited
Loading

@jtomaszewski I have tested with 2.4.1 and did not require any patches.

@jtomaszewski jtomaszewski mentioned this issue Dec 20, 2020
Merged
@erfanimani
Copy link

Magepack is running fine under 2.4.1 here.

Without more info from OP I suggest the ticket to be closed.

@krzksz krzksz closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@delyriand @krzksz @erfanimani @jtomaszewski @gaiterjones @good-geek