From ad30a5f89f4bf710dc5a498cc91db2ff718b1f8f Mon Sep 17 00:00:00 2001
From: Jeremy Magland <jmagland@flatironinstitute.org>
Date: Tue, 2 Apr 2024 10:53:23 -0400
Subject: [PATCH] curation kbd shortcuts

---
 .../SortingCuration2View.tsx                  | 53 ++++++++++++++++++-
 .../SortingSelectionView.tsx                  | 34 ++----------
 2 files changed, 55 insertions(+), 32 deletions(-)

diff --git a/gui/src/libraries/spike-sorting-views/view-sorting-curation-2/SortingCuration2View.tsx b/gui/src/libraries/spike-sorting-views/view-sorting-curation-2/SortingCuration2View.tsx
index cb9243b..44e01ac 100644
--- a/gui/src/libraries/spike-sorting-views/view-sorting-curation-2/SortingCuration2View.tsx
+++ b/gui/src/libraries/spike-sorting-views/view-sorting-curation-2/SortingCuration2View.tsx
@@ -1,10 +1,11 @@
 import { Checkbox } from "@material-ui/core";
 import { SortingCuration, useSortingCuration } from "..";
 import { useSelectedUnitIds } from "..";
-import { FunctionComponent, useCallback, useEffect, useMemo } from "react";
+import { FunctionComponent, KeyboardEvent, useCallback, useEffect, useMemo } from "react";
 import { SortingCuration2ViewData } from "./SortingCuration2ViewData";
 import SaveControl from "./SaveControl";
 import { useUrlState } from "@fi-sci/figurl-interface";
+import { globalKeyHandler } from "../../../globalKeyHandler";
 
 type Props = {
     data: SortingCuration2ViewData
@@ -55,6 +56,56 @@ const SortingCuration2View: FunctionComponent<Props> = ({data, width, height}) =
         }
     }, [selectedUnitIds, sortingCurationDispatch])
 
+    useEffect(() => {
+        const cb = (event: KeyboardEvent) => {
+            if (event.shiftKey) {
+                let choiceIndex = -1
+                if (event.key === '!') choiceIndex = 0
+                if (event.key === '@') choiceIndex = 1
+                if (event.key === '#') choiceIndex = 2
+                if (event.key === '$') choiceIndex = 3
+                if (event.key === '%') choiceIndex = 4
+                if (event.key === '^') choiceIndex = 5
+                if (event.key === '&') choiceIndex = 6
+                if (event.key === '*') choiceIndex = 7
+                if (event.key === '(') choiceIndex = 8
+                if (event.key === ')') choiceIndex = 9
+                if ((0 <= choiceIndex) && (choiceIndex < labelChoices.length)) {
+                    const label = labelChoices[choiceIndex]
+                    handleClick(label, labelSelectedStates[label])
+                }
+                if (event.key === 'ArrowDown') {
+                    if (selectedUnitIds.length === 0) return
+                    const lastUnitSelected = selectedUnitIds[selectedUnitIds.length - 1]
+                    const index = orderedUnitIds.indexOf(lastUnitSelected)
+                    if (index < 0) return
+                    if (index === orderedUnitIds.length - 1) return
+                    const id = orderedUnitIds[index + 1]
+                    unitIdSelectionDispatch({
+                        type: 'SET_SELECTION',
+                        incomingSelectedUnitIds: [id]
+                    })
+                }
+                if (event.key === 'ArrowUp') {
+                    if (selectedUnitIds.length === 0) return
+                    const firstUnitSelected = selectedUnitIds[0]
+                    const index = orderedUnitIds.indexOf(firstUnitSelected)
+                    if (index < 0) return
+                    if (index === 0) return
+                    const id = orderedUnitIds[index - 1]
+                    unitIdSelectionDispatch({
+                        type: 'SET_SELECTION',
+                        incomingSelectedUnitIds: [id]
+                    })
+                }
+            }
+        }
+        globalKeyHandler.registerCallback(cb)
+        return () => {
+            globalKeyHandler.deregisterCallback(cb)
+        }
+    }, [selectedUnitIds, orderedUnitIds, labelChoices, handleClick, unitIdSelectionDispatch])
+
     const handleMergeSelected = useCallback(() => {
         if (!sortingCurationDispatch) return
         sortingCurationDispatch({
diff --git a/gui/src/libraries/view-sorting-selection/SortingSelectionView.tsx b/gui/src/libraries/view-sorting-selection/SortingSelectionView.tsx
index bf5da23..657d58b 100644
--- a/gui/src/libraries/view-sorting-selection/SortingSelectionView.tsx
+++ b/gui/src/libraries/view-sorting-selection/SortingSelectionView.tsx
@@ -1,11 +1,8 @@
-import { Button, Checkbox } from "@material-ui/core";
-import { SortingCuration, useSortingCuration } from "../spike-sorting-views";
 import { useUrlState } from "@fi-sci/figurl-interface";
-import { useSelectedUnitIds } from "../spike-sorting-views";
-import { FunctionComponent, KeyboardEvent, useCallback, useEffect, useMemo } from "react";
-import { getAbbreviatedUnitIdsString, getAllLabelChoices } from "../spike-sorting-views";
+import { Button, Checkbox } from "@material-ui/core";
+import { FunctionComponent, useCallback, useMemo } from "react";
+import { SortingCuration, getAbbreviatedUnitIdsString, getAllLabelChoices, useSelectedUnitIds, useSortingCuration } from "../spike-sorting-views";
 import { SortingSelectionViewData } from "./SortingSelectionViewData";
-import { globalKeyHandler } from "../../globalKeyHandler";
 
 type Props = {
     data: SortingSelectionViewData
@@ -87,31 +84,6 @@ const SortingSelectionView: FunctionComponent<Props> = ({width, height}) => {
             visibleUnitIds: restrictedUnitIds
         })
     }, [selectedUnitIds, updateUrlState, restrictedUnitIds])
-    useEffect(() => {
-        const cb = (event: KeyboardEvent) => {
-            if (event.shiftKey) {
-                let choiceIndex = -1
-                if (event.key === '!') choiceIndex = 0
-                if (event.key === '@') choiceIndex = 1
-                if (event.key === '#') choiceIndex = 2
-                if (event.key === '$') choiceIndex = 3
-                if (event.key === '%') choiceIndex = 4
-                if (event.key === '^') choiceIndex = 5
-                if (event.key === '&') choiceIndex = 6
-                if (event.key === '*') choiceIndex = 7
-                if (event.key === '(') choiceIndex = 8
-                if (event.key === ')') choiceIndex = 9
-                if (choiceIndex < 0) return
-                if (choiceIndex >= labelChoices.length) return
-                const label = labelChoices[choiceIndex]
-                handleClick(label, labelSelectedStates[label])
-            }
-        }
-        globalKeyHandler.registerCallback(cb)
-        return () => {
-            globalKeyHandler.deregisterCallback(cb)
-        }
-    }, [selectedUnitIds, restrictedUnitIds, handleClick, labelChoices, labelSelectedStates])
     return (
         <div style={{position: 'absolute', width, height, overflowY: 'auto'}}>
             <h3>Selection</h3>