Fix CSS/JS Issues + QOL Improvements #108

1337Syntax · 2024-05-04T18:08:00Z

Issues Addressed in this PR:

Fixed Missing Embed Colours
Fixed Emojis being Mis-Aligned on Button Labels & Normal Text Content
Fixed the Un-Equal Footer Width (Padding on the Left was More than the Right Side)
Fixed User Pop-Out not Appearing
Fixed Scrolling when Clicking Message Replies/etc
Fixed quick_export() (Was Raising due to attachment_handler Arg Missing)

New Features:

Hover on User Avatars
Clicking Buttons/Images/Assets will Open in New Tab
Changed BOT Tag to the New APP Tag
Slightly Updated README on the AttachmentHandler Section

README.md

1337Syntax · 2024-05-04T23:10:46Z

Oops, I forgot I was on master branch, my mistake. Reverted those README Changes @mahtoid.

doluk

Nice pr, a lot of new stuff. Some of the changes would need a little more explanation for me to understand what/why it was changed

chat_exporter/construct/assets/attachment.py

chat_exporter/construct/assets/component.py

chat_exporter/html/attachment/audio.html

chat_exporter/html/base.html

mahtoid · 2024-05-17T01:16:43Z

It would be good if you could provide screenshots on changed too where applicable. I won't be able to spin up and check anytime soon, so screenshots will give me some sanity 👀

1337Syntax · 2024-05-17T15:16:40Z

It would be good if you could provide screenshots on changed too where applicable. I won't be able to spin up and check anytime soon, so screenshots will give me some sanity 👀

Here are 2 links to transcripts generated that should hopefully work and show some of the changes.

From those you should be able to see the difference in embed colours, emoji mis-alignment, button padding, footer width, user pop-outs, hover on avatar and scrolling on messages.

For reference, they were generated via the following:

transcript = await chat_exporter.raw_export(
    channel=channel,
    messages=messages,
    tz_info="UTC",
    bot=bot,
    military_time=True,
    fancy_times=True,
    support_dev=False
)

I also did a commit to fix the bug where hovering over a message shows "AM/PM" on the left of it instead of the actual time "MIN:HR".

chat_exporter/construct/assets/component.py

chat_exporter/html/component/component_button.html

pyproject.toml

chat_exporter/html/base.html

chat_exporter/construct/message.py

chat_exporter/ext/html_generator.py

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

1337Syntax · 2024-05-20T15:52:40Z

Thanks for the suggestions @doluk, I've committed those in.

doluk · 2024-05-20T15:56:22Z

@1337Syntax could you please generate the example again? once with military and once with 12h time format?

1337Syntax · 2024-05-20T16:27:38Z

@1337Syntax could you please generate the example again? once with military and once with 12h time format?

doluk · 2024-05-20T16:41:27Z

the time is 24 h in both 🧐

1337Syntax · 2024-05-20T17:02:34Z

the time is 24 h in both 🧐

Seems that only the timestamp in the aside message part actually checks for military time usage whereas the other timestamps do not. I have pushed a commit to now fix that.

doluk · 2024-05-20T17:12:07Z

looks good to me now! Thank you for the work and the fast changes!

* Fix type hinting compatibility with Python < 3.9 (#105) * Merging master in to 2.8.0 (#110) * Versioning * Fix discord import for wrapper namespaces != discord (#104) * Versioning --------- Co-authored-by: mahtoid <git@mahto.id> Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Fix CSS/JS Issues + QOL Improvements (#108) * Versioning * Fix discord import for wrapper namespaces != discord (#104) * Versioning * Fix quick_export() Missing Argument * Remove Use of 'proxy_url' due to Discord's CDN Changes * Fix Embed Colour & Reduce Unnecessary Gaps * Fix Emoji Mis-Alignment * Fix Button Label Padding * Equalise Footer Width * Fix User Pop-Out * Add Hover on User Avatars * Fix Scrolling to Messages * Open Buttons & Images in New Tabs + Fix Audio Container * Change BOT Tag to New APP Tag * Update README * Add .vscode to Git-Ignore * Update README.md for my Fork * Update README.md * Revert README Installation Changes * Revert Asset URL Change back to Proxy URL * Fixed Message Aside Timestamp * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/html/component/component_button.html Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/html/base.html Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/assets/component.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update chat_exporter/construct/message.py Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Refactoring * Fixed Military Times --------- Co-authored-by: mahtoid <git@mahto.id> Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> * Update discord link * Fix a bug within LocalAttachmentHandler and regex search returning None causing AttributeError & add html meta tags to transcript (#111) * Ensure unique filenames Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Add html meta tags Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Fix Local File handler Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Fix regex search returning no match causing AttributeError Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Exchange uuid4 with EPOCH timestamp with ms Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> --------- Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Interaction Message (metadata) * Backport Interaction * interaction name --------- Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> Co-authored-by: Argon <laiyeqi@gmail.com> Co-authored-by: mahtoid <git@mahto.id> Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> Co-authored-by: syntax <me@syntax.fo>

mahtoid and others added 18 commits April 1, 2024 14:05

Versioning

ea00a51

Fix discord import for wrapper namespaces != discord (#104)

891414f

Versioning

7372cb2

Fix quick_export() Missing Argument

d7119e2

Remove Use of 'proxy_url' due to Discord's CDN Changes

a42b2e8

Fix Embed Colour & Reduce Unnecessary Gaps

0ab7281

Fix Emoji Mis-Alignment

11b5797

Fix Button Label Padding

e0648bd

Equalise Footer Width

37cc188

Fix User Pop-Out

beb0dfc

Add Hover on User Avatars

03c3885

Fix Scrolling to Messages

8ec2916

Open Buttons & Images in New Tabs + Fix Audio Container

317e150

Change BOT Tag to New APP Tag

07e3080

Update README

48c661a

Add .vscode to Git-Ignore

1d64de0

Update README.md for my Fork

4748d8d

Update README.md

1ed51e9

1337Syntax changed the title ~~Fix CSS Issues~~ Fix CSS/JS Issues + QOL Improvements May 4, 2024

mahtoid reviewed May 4, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

mahtoid reviewed May 4, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

Revert README Installation Changes

e66bee2

doluk reviewed May 14, 2024

View reviewed changes

chat_exporter/construct/assets/attachment.py Outdated Show resolved Hide resolved

chat_exporter/construct/assets/component.py Outdated Show resolved Hide resolved

chat_exporter/html/attachment/audio.html Show resolved Hide resolved

chat_exporter/html/base.html Show resolved Hide resolved

mahtoid changed the base branch from master to 2.8.0 May 17, 2024 01:17

1337Syntax added 2 commits May 17, 2024 12:21

Revert Asset URL Change back to Proxy URL

616affa

Fixed Message Aside Timestamp

1220ba6

doluk suggested changes May 20, 2024

View reviewed changes

1337Syntax and others added 10 commits May 20, 2024 16:40

Update chat_exporter/construct/assets/component.py

8e9bf4c

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Update chat_exporter/construct/assets/component.py

4ae7b20

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Update chat_exporter/construct/assets/component.py

a188924

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Update chat_exporter/construct/assets/component.py

4b50836

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Update chat_exporter/construct/assets/component.py

53875e1

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Update chat_exporter/html/component/component_button.html

602136b

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Update chat_exporter/html/base.html

0dab1d9

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Update chat_exporter/construct/assets/component.py

ffebe66

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Update chat_exporter/construct/message.py

d189141

Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com>

Refactoring

67f126a

Fixed Military Times

a418583

doluk approved these changes May 20, 2024

View reviewed changes

mahtoid merged commit acff601 into mahtoid:2.8.0 May 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CSS/JS Issues + QOL Improvements #108

Fix CSS/JS Issues + QOL Improvements #108

1337Syntax commented May 4, 2024 •

edited

Loading

1337Syntax commented May 4, 2024

doluk left a comment

mahtoid commented May 17, 2024

1337Syntax commented May 17, 2024 •

edited

Loading

1337Syntax commented May 20, 2024

doluk commented May 20, 2024

1337Syntax commented May 20, 2024

doluk commented May 20, 2024

1337Syntax commented May 20, 2024

doluk commented May 20, 2024

Fix CSS/JS Issues + QOL Improvements #108

Fix CSS/JS Issues + QOL Improvements #108

Conversation

1337Syntax commented May 4, 2024 • edited Loading

1337Syntax commented May 4, 2024

doluk left a comment

Choose a reason for hiding this comment

mahtoid commented May 17, 2024

1337Syntax commented May 17, 2024 • edited Loading

1337Syntax commented May 20, 2024

doluk commented May 20, 2024

1337Syntax commented May 20, 2024

doluk commented May 20, 2024

1337Syntax commented May 20, 2024

doluk commented May 20, 2024

1337Syntax commented May 4, 2024 •

edited

Loading

1337Syntax commented May 17, 2024 •

edited

Loading