This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
Enable caching in RoutingNode. #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Aug 31, 2015
ghost
commented
|
(maidsafe_highfive has picked a reviewer for you, use r? to override) |
| } | ||
| return None; | ||
| } | ||
| DataRequest::StructuredData(data_name, version) => { |
There was a problem hiding this comment.
It is only a name, but for code clarity it is worthwhile fixing, the u64 in the DataRequest::StructuredData(identifier_name, type_tag) - it is not the version number of the StructuredData (the SAFE network does not maintain the version history of an SD, the internal version number functions only to linearise the history in clients control)
|
looks good to me |
benjaminbollen
pushed a commit
that referenced
this pull request
Sep 7, 2015
Enable caching in RoutingNode.
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.