Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sn_client): Basic documentation #1946

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

mazzi
Copy link
Contributor

@mazzi mazzi commented Jul 5, 2024

Description

Adding basic documentation for sn_client.

Description, features, examples.

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

@mazzi mazzi requested a review from RolandSherwin July 5, 2024 16:36
println!("Payment for chunks: {:?}", payment.storage_cost);

// Upload the file. First add the file to the folder
//TODO:

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
use tokio::main;
use xor_name::XorName;

// FIXME: This example is WIP.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@mazzi mazzi force-pushed the doc_sn_client branch 2 times, most recently from 1e96457 to 1048c9f Compare July 5, 2024 16:43
@mazzi mazzi force-pushed the doc_sn_client branch 2 times, most recently from 3346100 to c377d80 Compare July 11, 2024 15:02
@mazzi mazzi requested review from b-zee and grumbach July 11, 2024 15:19
@mazzi mazzi marked this pull request as ready for review July 15, 2024 09:09
sn_client/README.md Outdated Show resolved Hide resolved
sn_client/README.md Outdated Show resolved Hide resolved
sn_client/src/api.rs Outdated Show resolved Hide resolved
sn_client/README.md Outdated Show resolved Hide resolved
@mazzi mazzi requested a review from b-zee July 15, 2024 09:37
@mazzi mazzi force-pushed the doc_sn_client branch 2 times, most recently from edb11fb to e162ada Compare July 15, 2024 10:37
Copy link
Member

@maqi maqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR has 23 commits in the change history, but just 43 lines changed ?

@mazzi mazzi requested a review from maqi July 15, 2024 11:16
@mazzi mazzi requested a review from b-zee July 15, 2024 11:24
@b-zee b-zee added this pull request to the merge queue Jul 15, 2024
Merged via the queue into maidsafe:main with commit fed311b Jul 15, 2024
43 checks passed
@mazzi mazzi deleted the doc_sn_client branch July 15, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants