feat(network): accumulate split scratchpads #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
approved these changes
Nov 7, 2024
RolandSherwin
force-pushed
the
scratchpad_split_record
branch
from
a98b336 to
458a0ff
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -613,47 +614,83 @@ | |||
| continue; | |||
| }; | |||
| let kind = record_kind.get_or_insert(header.kind); | |||
| // FIXME: the first record dictates the kind, but we should check all records are of the same kind. | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
RolandSherwin
force-pushed
the
scratchpad_split_record
branch
from
458a0ff to
4972e3e
Compare
RolandSherwin
force-pushed
the
scratchpad_split_record
branch
from
4972e3e to
d15ae75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.