Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: allow creation of a register with optional value #2506

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

happybeing
Copy link
Contributor

Description

Makes the value passed to register create functions optional.

@b-zee I think I had this in an earlier PR so maybe the idea was rejected, but if not here it is.

Related Issue

Fixes #<issue_number> (if applicable).

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

@happybeing happybeing force-pushed the create-register-option-value branch from 5be92d4 to 6d8ffe6 Compare December 8, 2024 17:51
@happybeing happybeing force-pushed the create-register-option-value branch from 6d8ffe6 to 0e5a1a9 Compare December 8, 2024 17:57
@b-zee b-zee added this pull request to the merge queue Dec 9, 2024
Merged via the queue into maidsafe:main with commit ca1bdff Dec 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants