Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestingAdapter deliver function doesn't return the same type as ExternalSmtpAdapter #48

Open
martinos opened this issue Apr 30, 2016 · 3 comments
Labels

Comments

@martinos
Copy link
Contributor

The TestingAdapter.deliver function returns a Task, however the ExternalSmtpAdapter.deliver returns a tuple: {:ok, message}.

I think that both function should return the same type, it would make tests behave more like production code.

@IamfromSpace
Copy link

+1 for this. Will be pointing to your branch until the PR goes through.

@hamann
Copy link
Contributor

hamann commented Jun 7, 2016

@kamilc Is there a reason to have different results? Writing code with tests and matching against result isn't possible because of this

@zberkom
Copy link

zberkom commented Aug 8, 2016

👍 Experiencing the same issue here. Both adapters should return a Task.

@skosch skosch added the bug label Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants