Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: ability to not strip test-selectors in addon builds? #95

Closed
lukemelia opened this issue Apr 21, 2017 · 5 comments
Closed

Discussion: ability to not strip test-selectors in addon builds? #95

lukemelia opened this issue Apr 21, 2017 · 5 comments

Comments

@lukemelia
Copy link

lukemelia commented Apr 21, 2017

Here's our situation: we are extracting an addon out of app. The tests for this app use ember-test-selectors. Once extracted to an addon, though, the same tests do not pass because when the addon builds, test selectors are stripped.

It would seem to be a inarguably good thing to allow addon authors to use ember-test-selectors to test their addons.

In addition, I would like to propose that apps be able to not strip test selectors when building their addon for tests, either by default or by configuration.

Thoughts? Is this already possible and I am missing it?

@Turbo87
Copy link
Collaborator

Turbo87 commented Apr 21, 2017

@lukemelia have you seen https://github.com/simplabs/ember-test-selectors#configuration? I'm not sure if that covers your use case?

@lukemelia
Copy link
Author

@Turbo87 In an addon that configuration affects the dummy app, but not the addon/ build

@Turbo87
Copy link
Collaborator

Turbo87 commented Apr 21, 2017

I'm not sure I'm following. Do you have an example repo somewhere that I can take a look at?

@lukemelia
Copy link
Author

@Turbo87 I just pushed a simple example app here: https://github.com/lukemelia/ets-addon-example, including a failing test that demonstrates the issue.

@Turbo87
Copy link
Collaborator

Turbo87 commented May 3, 2017

@lukemelia haven't forgotten about you, just haven't found the time yet, sorry 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants