Regression: Could not find a declaration file for module 'qunit-dom' on v1.6.0-beta.1

[johanrd]

1. Clone this repo: https://github.com/johanrd/qunit-dom-typescript-reproduction
2. Run tsc, and experience the following typescript errors:

machine:qunit-dom-typescript-reproduction user$ tsc
tests/acceptance/application-test.ts:13:12 - error TS2339: Property 'dom' does not exist on type 'Assert'.

13     assert.dom('#ember-welcome-page-id-selector').exists();
              ~~~

tests/test-helper.ts:5:23 - error TS7016: Could not find a declaration file for module 'qunit-dom'. '…/qunit-dom-typescript-reproduction/node_modules/qunit-dom/index.js' implicitly has an 'any' type.
  Try `npm install @types/qunit-dom` if it exists or add a new declaration (.d.ts) file containing `declare module 'qunit-dom';`

5 import { setup } from 'qunit-dom';

yarn add @types/qunit-dom does not make any difference (as expected from deprecation).

Have I missed something from the migration guide and/or readme? Or is it an actual regression on v1.6.0-beta.1?
thanks!

[Turbo87]

@rwjblue @scalvert could one of you have a look at ⬆️ ? 🙏

thanks for the feedback @johanrd! this does indeed look like a regression to me.

[rwjblue]

Yep. Will review, thank you for the reproduction!!

[scalvert]

Will also take a peek.

[scalvert]

Removing my local dist directory and rebuilding with 1.6.0-beta.1 does appear to build without a qunit-dom.d.ts. This is likely due to the name munging that we've done to support the old and new versions.

[scalvert]

@johanrd I tested this fix in your provided reproduction and it builds fine. Thanks for the helpful repro!

[johanrd]

@scalvert Thanks for looking into this! – I ran a test now from you PR, and I actually still get the same errors:/?

See updated repo for reproduction.

[scalvert]

Hey @johanrd,

How are you testing the changes?

[johanrd]

On https://github.com/johanrd/qunit-dom-typescript-reproduction:

$ yarn remove qunit-dom
$ yarn cache clean qunit-dom
$ rm -rf node_modules && rm yarn.lock
$ yarn install
$ yarn add https://github.com/simplabs/qunit-dom#e654d0e1c10fdb2b96f0255775ad66a2c0b24193 --dev
$ tsc

tests/acceptance/application-test.ts:13:12 - error TS2339: Property 'dom' does not exist on type 'Assert'.

13     assert.dom('#ember-welcome-page-id-selector').exists();
              ~~~

tests/test-helper.ts:5:23 - error TS7016: Could not find a declaration file for module 'qunit-dom'. '/Users/johanroed/rendra/qunit-dom-typescript-reproduction/node_modules/qunit-dom/index.js' implicitly has an 'any' type.
  Try `npm install @types/qunit-dom` if it exists or add a new declaration (.d.ts) file containing `declare module 'qunit-dom';`

5 import { setup } from 'qunit-dom';
                        ~~~~~~~~~~~


Found 2 errors.

See commit 7ae45ad
FWIW: VS Code outputs the same errors as tsc

[scalvert]

OK, that's not going to be sufficient to test this, as qunit-dom is built and rolled up before it's published. Try this:

• cd qunit-dom-typescript-reproduction
• yarn add https://github.com/simplabs/qunit-dom#e654d0e1c10fdb2b96f0255775ad66a2c0b24193 --dev
• cd node_modules/qunit-dom (this will install qunit-dom's dependencies and build/rollup the package
• cd ../.. && yarn build (running yarn build is more appropriate than running tsc since it runs Ember's build, which in turn will compile typescript)

[johanrd]

Ah, ok, thanks – I can verify that it works after running yarn inside node_modules/qunit-dom 👌

[scalvert]

Awesome. Thanks for testing this out!