Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated ESLint rules #885

Closed
MrChocolatine opened this issue Nov 14, 2020 · 0 comments · Fixed by #924
Closed

Duplicated ESLint rules #885

MrChocolatine opened this issue Nov 14, 2020 · 0 comments · Fixed by #924
Labels
internal

Comments

@MrChocolatine
Copy link

The rules no-dupe-class-members and no-undef are currently set to off:
https://github.com/simplabs/qunit-dom/blob/6c31d65d825c8c09fab1c4f604b8a89945c06e11/.eslintrc.js#L30-L32

However, as your configuration extends plugin:@typescript-eslint/eslint-recommended, these rules are already disabled:
https://github.com/typescript-eslint/typescript-eslint/blob/2326238738c95acfc14c17f9b16798f1de6d267f/packages/eslint-plugin/src/configs/eslint-recommended.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicated eslint rules czikarito/qunit-dom
2 participants
@Turbo87 @MrChocolatine