Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver OTPW cannot be cleared or ignored #1955

Closed
miklschmidt opened this issue Jul 21, 2024 · 9 comments · Fixed by #1956
Closed

Driver OTPW cannot be cleared or ignored #1955

miklschmidt opened this issue Jul 21, 2024 · 9 comments · Fixed by #1956
Labels
⚡ Type: Bug Something isn't working

Comments

@miklschmidt
Copy link

miklschmidt commented Jul 21, 2024

Mainsail Version:

2.12.0

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

A lot of buttons that do nothing. This seems unintentional.

driver-temp-warning.mp4

It would be nice if they worked. Currently you cannot avoid this warning if you want to get the maximum out of a set of 2209 sticks for example, and as such this is just an annoyance and not very helpful.

What did you expect to happen instead?

The notification to be dismissed / ignored, or worst case scenario that the buttons were disabled.

How to reproduce this bug?

Either generate the OTPW flag on a driver, or just unconditionally push it to the notification list in the client code since it's a mainsail-only implementation.

Additional information:

No response

@sbtoonz
Copy link

sbtoonz commented Aug 5, 2024

image
appears to still be present in 2.12 release

@meteyou
Copy link
Member

meteyou commented Aug 5, 2024

@sbtoonz pls post a video...

@sbtoonz
Copy link

sbtoonz commented Aug 5, 2024

5.Printing.-.ETA_.07_31.PM.-.Corner.Skirt.X2_ASA_8h35m.gcode-.Trident.-.Google.Chrome.2024-08-05.08-56-15.mp4

@meteyou
Copy link
Member

meteyou commented Aug 5, 2024

@sbtoonz pls try a reload without cache (ctrl + shift + f5 on windows)

@sbtoonz
Copy link

sbtoonz commented Aug 5, 2024

6.Printing.-.ETA_.07_32.PM.-.Corner.Skirt.X2_ASA_8h35m.gcode-.Trident.-.Google.Chrome.2024-08-05.08-59-22.mp4

@sbtoonz
Copy link

sbtoonz commented Aug 5, 2024

force cache reload not yielding any different outcome

@meteyou
Copy link
Member

meteyou commented Aug 5, 2024

ohhh... @sbtoonz pls check the PR for this bug itself. this one is not even merged yet (waiting for a review) and therefore not yet released!

(and the initial bug report also describe, that this issue is in v2.12.0)

@sbtoonz
Copy link

sbtoonz commented Aug 5, 2024

Ah I'll pull this down then :)

@meteyou
Copy link
Member

meteyou commented Aug 5, 2024

You can download a build from the ci chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants