Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWM Fan Flyout has dual check boxes for 'Show PWM speed in chart' #799

Closed
TodWulff opened this issue May 13, 2022 · 3 comments · Fixed by #802
Closed

PWM Fan Flyout has dual check boxes for 'Show PWM speed in chart' #799

TodWulff opened this issue May 13, 2022 · 3 comments · Fixed by #802
Labels
⚡ Type: Bug Something isn't working

Comments

@TodWulff
Copy link

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

https://i.imgur.com/chPCsEa.png

Redundant 'Show PWM speed in chart' control in PWM Fan Flyout from Temperatures panel.

What did you expect to happen instead?

Have only a single check box for showing/hiding the PWM speed.

How to reproduce this bug?

Have a PWM Fan configured in Klipper and then in Mainsail, click a PWM Fan Icon or Name in the temp panel. Flyout depicts dual 'Show PWM speed in chart' checkbox controls

Additional information:

Noted this on 2.2.0-alpha and mentioned it.

@TodWulff TodWulff added the ⚡ Type: Bug Something isn't working label May 13, 2022
dw-0 added a commit to dw-0/mainsail that referenced this issue May 13, 2022
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@dw-0
Copy link
Member

dw-0 commented May 13, 2022

Hi, thanks for reporting that issue!
I think i found the culprit and made a PR with a fix for it.

If you are familiar with manually installing Mainsail and don't mind trying to check out the fix, you can download an automatically generated build from here:
https://github.com/mainsail-crew/mainsail/actions/runs/2319144474

Feel free to install it temporarily for checking if the issue was also resolved for you. Feedback is always appreciated!

@TodWulff
Copy link
Author

I'll endeavor to do so today. Thanks for the quick turn on a possible resolution.

meteyou added a commit that referenced this issue May 15, 2022
Co-authored-by: Stefan Dej <meteyou@gmail.com>
@TodWulff
Copy link
Author

I'll endeavor to do so today. Thanks for the quick turn on a possible resolution.

I confirm that this looks to be fixed in 2.2.0-beta3. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants