Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp chart shows "null RPM" for fans w/o tachometer pins defined #818

Closed
TodWulff opened this issue May 17, 2022 · 2 comments · Fixed by #820
Closed

Temp chart shows "null RPM" for fans w/o tachometer pins defined #818

TodWulff opened this issue May 17, 2022 · 2 comments · Fixed by #820
Labels
Is: UI/UX Anything referencing UI/UX Prio: 2 Medium 🚦 Status: 1 - Ready ⚡ Type: Bug Something isn't working

Comments

@TodWulff
Copy link

TodWulff commented May 17, 2022 •
edited
Loading

Requested feature:

https://i.imgur.com/xOmwF1T.png

If possible, when a fan doesn't have a tach input defined, can the 'null RPM' be suppressed on the Temp table.

Just a low priority nice to have. TIA for any consideration.

Solves the following problem:

Simply provides a more elegant less cluttered implementation.

Additional information:

No response
@TodWulff TodWulff added the 💡 Type: FR Requests a new feature label May 17, 2022
@TodWulff TodWulff changed the title {FR] Suppress null RPM on temp chart for Fans w/o tach input defined [FR] Suppress null RPM on temp chart for Fans w/o tach input defined May 17, 2022
@dw-0
Copy link
Member

dw-0 commented May 17, 2022

Thanks for the request. That makes definitely sense to me!

@dw-0 dw-0 added 💡 Type: Improve Requests an improvement Prio: 2 Medium Is: UI/UX Anything referencing UI/UX 🚦 Status: 1 - Ready labels May 17, 2022
@dw-0
Copy link
Member

dw-0 commented May 17, 2022

I already wondered why that should even happen and display null. Now looking at the code, it was definitely not intended to be shown! So you found a bug im going to fix! I will re-label this issue from a feature request to a bug report.

Thanks again!

@dw-0 dw-0 added ⚡ Type: Bug Something isn't working and removed 💡 Type: Improve Requests an improvement 💡 Type: FR Requests a new feature labels May 17, 2022
@dw-0 dw-0 changed the title [FR] Suppress null RPM on temp chart for Fans w/o tach input defined Temp chart shows "null RPM" for fans w/o tachometer pins defined May 17, 2022
@dw-0 dw-0 linked a pull request May 17, 2022 that will close this issue
fix: do not show null RPM in temp chart (fixes #818) #820
Merged
@dw-0 dw-0 changed the title Temp chart shows "null RPM" for fans w/o tachometer pins defined [v2.2.0-beta3] Temp chart shows "null RPM" for fans w/o tachometer pins defined May 18, 2022
@dw-0 dw-0 changed the title [v2.2.0-beta3] Temp chart shows "null RPM" for fans w/o tachometer pins defined Temp chart shows "null RPM" for fans w/o tachometer pins defined May 18, 2022
meteyou pushed a commit that referenced this issue May 18, 2022
@dw-0
fix: do not show null RPM in temp chart (fixes #818) (#820)
76cedb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Is: UI/UX Anything referencing UI/UX Prio: 2 Medium 🚦 Status: 1 - Ready ⚡ Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not show null RPM in temp chart (fixes #818) dw-0/mainsail
2 participants
@TodWulff @dw-0