Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Heightmap): improve input validation for rename profile dialog #1002

Merged
merged 7 commits into from
Aug 6, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Aug 4, 2022

Solves the following problem:

Previously it was possible to:

  • submit the rename dialog if the input field was empty
  • rename a profile to a name that already exists
  • rename a profile to 'default', the name 'default' is reserved by Klipper and will result in an error, making the profile to disappear

This PR will fix all the issues above by disabling the rename button in the rename dialog if one of the cases applies.

image
image
image
image

Signed-off-by: Dominik Willner th33xitus@gmail.com

dw-0 added 6 commits August 4, 2022 10:22
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@dw-0 dw-0 added this to the v2.3.0 milestone Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Language file analysis report:

File Missing Keys Unused Keys
de.json 3 19
en.json 0 0

@dw-0 dw-0 requested a review from meteyou August 4, 2022 10:16
Copy link
Member

@meteyou meteyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

Language file analysis report:

File Missing Keys Unused Keys
de.json 3 19
en.json 0 0

@dw-0 dw-0 merged commit 4c9aab5 into mainsail-crew:develop Aug 6, 2022
@dw-0 dw-0 deleted the fix-rename-mesh-profile branch August 6, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants