fix: webcam name input alignment #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`align-center` caused some misalignment Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
meteyou
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem that will be solved:
The
align-centerclass caused some misalignmentSolution:
I haven't located the culprit of that cursor and label misalignment though, this is present in multiple input fields with form validation. It might be an issue introduced by ourself or a general Vuetify issue?Located and fixed with: #1020
Also solves:
Places the Target FPS and Rotate input fields into one line
A single line per input wastes a lot of space and is not even required on very small screen resolutions.
Signed-off-by: Dominik Willner th33xitus@gmail.com