Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global form validation error misalignment #1020

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Aug 11, 2022

Solves the following issue:

image

Solution

image

The solution does remove a css style that was applied to the label which was overwriting the font size of the label from 16px to 14px. Before we merge, we should re-evaluate if we want that again or if we apply the global 16px.

Signed-off-by: Dominik Willner th33xitus@gmail.com

@dw-0 dw-0 requested a review from meteyou August 11, 2022 16:03
@dw-0 dw-0 force-pushed the fix-misalignment branch from 9f14bf4 to 6a2dbe2 Compare August 11, 2022 16:07
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@dw-0 dw-0 changed the title fix: fixes the form validation misalignment fix: form validation error misalignment Aug 11, 2022
@dw-0 dw-0 added this to the v2.3.0 milestone Aug 11, 2022
@dw-0 dw-0 changed the title fix: form validation error misalignment fix: global form validation error misalignment Aug 12, 2022
@dw-0 dw-0 merged commit d8377ac into mainsail-crew:develop Aug 12, 2022
@dw-0 dw-0 deleted the fix-misalignment branch August 12, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants