Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve webcam settings logic and layout #1114

Merged
merged 7 commits into from
Oct 9, 2022
Merged

refactor: improve webcam settings logic and layout #1114

merged 7 commits into from
Oct 9, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Oct 8, 2022

  • disable 'save webcam' button if field 'name' is empty
  • layout of flip webcam image was changed, checkboxes are now in a single row, if the viewport width allows it.

Before:

image

After:

22-10-09_00-41-24_chrome

Signed-off-by: Dominik Willner th33xitus@gmail.com

dw-0 added 3 commits October 8, 2022 23:43
@dw-0
refactor: disable 'save webcam' button if field 'name' is empty
3c0d9fc 
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@dw-0
refactor: improve layout
2197caf 
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@dw-0
locales: translate new keys
c8b9bd3 
the majority of the keys were translated with the help of online translators

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

Language file analysis report:

File Missing Keys Unused Keys
da.json 15 0
de.json 0 0
en.json 0 0
es.json 34 0
fr.json 10 0
hu.json 33 0
it.json 191 0
ja.json 13 0
ko.json 36 0
nl.json 10 0
pl.json 33 0
ru.json 33 0
sv.json 151 0
tr.json 11 0
uk.json 10 0
zh.json 7 0
zh_TW.json 265 0

@meteyou
fix: add margin bottom fix of fail details of name field
7f1fc85 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

Language file analysis report:

File Missing Keys Unused Keys
da.json 15 0
de.json 0 0
en.json 0 0
es.json 34 0
fr.json 10 0
hu.json 33 0
it.json 191 0
ja.json 13 0
ko.json 36 0
nl.json 10 0
pl.json 33 0
ru.json 33 0
sv.json 151 0
tr.json 11 0
uk.json 10 0
zh.json 7 0
zh_TW.json 265 0

@dw-0 dw-0 marked this pull request as ready for review October 9, 2022 08:25
@dw-0
chore: revert usage of singleton tags to match code style
7f7ad54 
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@dw-0 dw-0 requested a review from meteyou October 9, 2022 08:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Language file analysis report:

File Missing Keys Unused Keys
da.json 15 0
de.json 0 0
en.json 0 0
es.json 34 0
fr.json 10 0
hu.json 33 0
it.json 191 0
ja.json 13 0
ko.json 36 0
nl.json 10 0
pl.json 33 0
ru.json 33 0
sv.json 151 0
tr.json 11 0
uk.json 10 0
zh.json 7 0
zh_TW.json 265 0

@dw-0
refactor: use scoped style and vue deep selector
103cd88 
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Language file analysis report:

File Missing Keys Unused Keys
da.json 15 0
de.json 0 0
en.json 0 0
es.json 34 0
fr.json 10 0
hu.json 33 0
it.json 191 0
ja.json 13 0
ko.json 36 0
nl.json 10 0
pl.json 33 0
ru.json 33 0
sv.json 151 0
tr.json 11 0
uk.json 10 0
zh.json 7 0
zh_TW.json 265 0

@dw-0
refactor: use deep selector for scss
f42b920 
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Language file analysis report:

File Missing Keys Unused Keys
da.json 15 0
de.json 0 0
en.json 0 0
es.json 34 0
fr.json 10 0
hu.json 33 0
it.json 191 0
ja.json 13 0
ko.json 36 0
nl.json 10 0
pl.json 33 0
ru.json 33 0
sv.json 151 0
tr.json 11 0
uk.json 10 0
zh.json 7 0
zh_TW.json 265 0

@dw-0 dw-0 merged commit d1cfe72 into mainsail-crew:develop Oct 9, 2022
@dw-0 dw-0 deleted the improve-webcam-settings branch October 9, 2022 16:45
@dw-0 dw-0 added this to the v2.4.0 milestone Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteyou meteyou meteyou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dw-0 @meteyou