Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add x_only and y_only option in timelapse park position #1231

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jan 15, 2023

this PR is related to this FR: mainsail-crew/moonraker-timelapse#74

Signed-off-by: Stefan Dej meteyou@gmail.com

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and zellneralex January 15, 2023 19:40
@zellneralex
Copy link
Member

Tested it with the build. looks OK

Copy link
Member

@zellneralex zellneralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it with the build, and looks OK.

Code review should be done by @th33xitus

@meteyou meteyou merged commit 2a924bc into mainsail-crew:develop Feb 12, 2023
@meteyou meteyou deleted the feat/add-park-only-xy-timelapse branch February 12, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants