locale(ko): update Korean localization #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a json modification error due to the i18n conversion tool problem and it was attached as LF, not CRLF with UTF-8(prettier on VSCode. so i fixed up it and uploaded again.
this is just test for pr
There was a json modification error due to the i18n conversion tool problem and it was attached as LF, not CRLF with UTF-8(prettier on VSCode. so i fixed up it and uploaded again. (also remove 2 unused keys)
i don't know why stucked at prettier test when i make PR even if 0 missing and 0 unused key. also using UTF-8, CRLF, 4 space for tab with prettier on VSC
There was a json modification error due to the i18n conversion tool problem and it was attached as LF, not CRLF with UTF-8(prettier on VSCode. so i fixed up it and uploaded again. (also remove 2 unused keys)
The composition of the existing Korean language pack and the new English language pack is different, so the Korean language pack has been re-modified based on the English language pack. But I don't know why the first line error in the ko.json file occurs in the prettier check when i push the PR to develope. i've check it again 0 missing key, 0 unused key, CRLF, UTF-8, 4 space, JSON format now.
let replace ko.json file with space 4 saved file
the korean language pack was different from the new version, so reworked based on the recently english language pack. 0 missing 0 unused keys with space 4, CRLF, UTF-8 with prettier on VSCode.
|
Language file analysis report:
|
ZISQO
changed the title
dw-0
changed the title
|
I really have no idea what your usual workflow for creating PRs is, but i think it's not required to always create a new Pull Request if you change something. The pull request will update if you make changes to your local branch and push it. |
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
|
Language file analysis report:
|
dw-0
approved these changes
May 3, 2023
** ya i gotti! and thax to merge it of! : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the korean language pack was different from the new version, so reworked based on the recently english language pack.
0 missing 0 unused keys with space 4, CRLF, UTF-8 with prettier on VSCode.
Signed-off-by: zisqo zisqofoto@gmail.com