Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale(zh_TW): update Chinese localization #1386

Merged
merged 5 commits into from
May 18, 2023

Conversation

BrownRhined
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
zh_TW.json 0 25

@dw-0 dw-0 changed the title Update zh_TW.json locale(zh_TW): update Chinese localization May 18, 2023
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 17 1
en.json 0 1
zh_TW.json 48 2

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
zh_TW.json 50 2

meteyou added 2 commits May 18, 2023 16:59
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
zh_TW.json 59 0

@meteyou meteyou merged commit 8481408 into mainsail-crew:develop May 18, 2023
@meteyou
Copy link
Member

meteyou commented May 18, 2023

thx for your PR!

i removed all unused keys form your translation and found 59 empty strings. its not good to have empty translations, because mainsail cannot display the fallback (english) instead of the missing translation for it.

i merged this translation, but if you have time to add the last missing translations, i would be happy if you create a new PR for this. Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants