-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add PWA caching and cache updater #1421
Conversation
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@QuinnDamerell if you want to double-check the cache function. This is the PR for it. |
Language file analysis report:
|
Co-authored-by: th33xitus <domwil1091+github@gmail.com>
Language file analysis report:
|
Amazing! Nice work! |
AFAIK a PWA doesn't work on a non-https based application. Aside from that, it looks good to me! |
I tested it with a reverse proxy to get a valid lets encrypted certificate. I also see very little use for single setups. This feature is more useful for octoprinteverywhere integration or similar use cases. Thx for your review! |
With pleasure! |
I didn’t think about this only working on https sites. That’s probably why more users didn’t hit this before now. But as you pointed out, for sites that reverse proxy Mainsail like mine, (https://octoeverywhere.com) having the local cache is so nice! @meteyou you’re welcome to use my service for testing if it helps you at all. It’s free and provides unlimited data, so it might be helpful to you. On top of that, I’m more than happy to add any features you need that would help you to test! It’s really a shame it’s not easier to generate per-user certs for .local domains. In modern times it would be nice to even have encryption on your LAN. |
Thx! I will test it with octoeverywhere (i have it also installed on my small V2). I used this guide for installing it: https://notthebe.ee/blog/easy-ssl-in-homelab-dns01/ The browser also blocked self-signed certs for PWA... So I think it's close to impossible for not linux experienced users to install a certificate for the printer him/her self... |
Nice! Yeah, I think the concept of SSL certs breaks down for .local domains, because half of an SSL cert asserts ownership over a unique domain. But many users could have |
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Description
This PR add PWA workbox to cache all assets to run Mainsail offline and add a updater function/dialog.
Related Tickets & Documents
no related tickes
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?