-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to re-arrange job queue's items #1692
feat: Add ability to re-arrange job queue's items #1692
Conversation
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
(second & next to last items) Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Mobile & Desktop Screenshots/RecordingsOne item only (no re-arrange) buttonsThree items, re-arrange buttons displayed for eachMultiple items, re-arrange first itemMultiple items, re-arrange second itemMultiple items, re-arrange middle itemMultiple items, re-arrange next to last itemMultiple items, re-arrange last itemMultiple items, job queue overflow (Dashboard only), re-arrange last DISPLAYED item (queue is longer)Multiple items, Files view, re-arrange second to last item |
Language file analysis report:
|
2 similar comments
Language file analysis report:
|
Language file analysis report:
|
c5921b8
to
5e9d618
Compare
Language file analysis report:
|
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
5e9d618
to
fd09c33
Compare
Language file analysis report:
|
1 similar comment
Language file analysis report:
|
Thx for the PR. Would it be also possible with a "drag & drop" option like the resort function of "expert macro panel"? |
Hi, I'm not sure if you asked me to do that in this PR, or is it technically possible to achieve that in the future (as in, in a separate PR), so I'll answer both:
|
@mdziekon Thank you for your reply. Please just let this PR open, and I'll take a closer look at it. Because the option "maintainers are allowed to edit this pull request", I can continue working on it. |
I'd just like to stop by and say thank you for this PR. This is exactly the feature I was just looking for at this very moment! 😃 Drag and drop support would be really nice, though. 👍 |
I just started using job queue and first thing i thought was it needs this feature. So as soon as I started searching for it I found this PR. Great job @mdziekon. I'm looking forward to use it as soon as it is merged. Is there a way to try it out sooner? |
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Description
This PR adds the ability to re-arrange job queue's items, by using the following actions:
All of the actions are available via the context menu (Right-click on the queue's entry). While "move up" & "move down" are probably not ideal for quick re-arrangements (drap & drop would be much easier to use), I think it's good enough for now, most definitely better than no such feature at all. The internal implementation is done is such a way, that if anyone would like to improve this by implementing the mentioned drag & drop, the re-arrangement "backend" is already there, ready to be reused. I think this could also be reused to implement the requested "Start printing from anywhere in the queue" feature, however I'm not versed enough in the Vue's ecosystem to implement that at this moment.
Since the modified component is properly being reused across Job Queue panel on the Dashboard and the Files list, the implemented features are available for both of these views.
Additional changes:
StatusPanelJobqueueEntry
component no longer relies of its status of being "first" to display the "print button"showPrintButtonForFirst
flag) clearly represents the purpose, while the previous implementation required internal knowledge to understand why the button was being displayed or notRelated Tickets & Documents
Mobile & Desktop Screenshots/Recordings
(see next comment)
[optional] Are there any post-deployment tasks we need to perform?
N/A