fix: file upload rate displays NaN instead of an actual value
#1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
Signed-off-by: Michał Dziekoński <michal.dziekonski+github@gmail.com>
mdziekon
changed the title
NaN instead of an actual value
meteyou
approved these changes
Feb 15, 2024
meteyou
changed the title
NaN instead of an actual valueNaN instead of an actual value
|
Thx for this fix! I didn't even notice this bug until just now. Looks like i overlooked an Axios update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incorrect upload (and download in GCode viewer, although barely noticeable) rate being displayed as
NaN, instead of an actual value.Problem is caused by an incorrectly used
progressEventargument of Axios'esonUploadProgresscallback, which exposes its own event object wrapper, instead the raw browser event (as I think someone has assumed, or maybe was the case in the past). Now, with Axios 1.x being used,onUploadProgresscallback exposesAxiosProgressEvent-typed interface (this PR also corrects typings usage, instead of the nasty implicitany).AxiosProgressEvent"documentation" for reference (typings, their official documentation does not seem to describe the relevant interface).Problem occurs on Firefox & Chromium based browsers.
Problem has been fixed for:
Related Tickets & Documents
N/A
Mobile & Desktop Screenshots/Recordings
Note: upload artificially slowed down for testing purposes
Before
After