Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timelapse): add warning if snapshoturl is set in moonraker #1921

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jun 26, 2024

Description

This PR adds a warning, when the user set the snapshoturl in the moonraker.conf and adds the warning when no webcam with snapshoturl is available.

Related Tickets & Documents

Discord support-forum post: https://discord.com/channels/758059413700345988/1247327991181344778

Mobile & Desktop Screenshots/Recordings

Warning with snapshoturl in the moonraker.conf:
image

Output without a webcam with snapshoturl:
image

[optional] Are there any post-deployment tasks we need to perform?

none

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0, rackrick and mryel00 June 26, 2024 18:27
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 26, 2024
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 2

this will fix, if the user only use moonraker.conf webcams

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 2

meteyou added 2 commits June 28, 2024 14:22
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 2

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 2

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 2

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 28, 2024
@meteyou meteyou merged commit c4fd167 into mainsail-crew:develop Jun 29, 2024
12 checks passed
@meteyou meteyou deleted the fix/timelapse-snapshoturl-moonraker branch June 29, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants