Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add output on connection dialog for unauthorized #1996

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Sep 6, 2024

Description

This PR adds an output for "Unauthorized" connections on the ConnectionDialog. Without this PR, the user would only see an endless initialize dialog.

Related Tickets & Documents

fixes #1971

Mobile & Desktop Screenshots/Recordings

before:
image

after:
image

[optional] Are there any post-deployment tasks we need to perform?

none

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and rackrick September 6, 2024 22:50
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 7, 2024
@meteyou meteyou changed the title feat: add output on connection dialog for unauthorized connections feat: add output on connection dialog for unauthorized Sep 7, 2024
@meteyou meteyou merged commit c2226dc into mainsail-crew:develop Sep 7, 2024
13 checks passed
@meteyou meteyou deleted the feat/add-unautorized-warning branch September 7, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display UI error(s) when interface is unable to initialize
2 participants