-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(History): adjust button tooltips to consistent style #2018
fix(History): adjust button tooltips to consistent style #2018
Conversation
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Reviewer's Guide by SourceryThis pull request adjusts the button tooltips in the HistoryListPanel.vue component to ensure a consistent style across all buttons. The changes include adding a missing tooltip for the settings button and standardizing the tooltip implementation for the delete button. File-Level Changes
Tips
|
Language file analysis report:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rackrick - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a redundant tooltip text for the settings menu. Consider removing the duplicate element inside the v-menu component.
- Consider adding or updating UI tests to cover these changes, if applicable.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Language file analysis report:
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rackrick - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Language file analysis report:
|
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Language file analysis report:
|
Signed-off-by: Patrick Stainbrook <patrick@hohestadt.de>
Language file analysis report:
|
Description
This PR adjust the style of the tooltips from the
HistoryListPanel.vue
to be alle the same.The Delete button had a different tooltip and the settings button had none.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Before:
After:
[optional] Are there any post-deployment tasks we need to perform?
Summary by Sourcery
Adjust button tooltips in the HistoryListPanel.vue component to ensure a consistent style by adding missing tooltips and modifying existing ones.
Bug Fixes: