Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StatusPanel): change tab text to icons #2054

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Nov 23, 2024

Description

This PR remove the text in the StatusPanel tabs and replace it with icons. This will also fix some space issues with long translations (like "Warteschlange" in german translations for "job queue").

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

before:
image

after:
image

[optional] Are there any post-deployment tasks we need to perform?

none

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and rackrick November 23, 2024 21:49
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 23, 2024
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 19 1
en.json 0 1

# Conflicts:
#	src/components/panels/StatusPanel.vue
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 27 1
en.json 0 1

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 24, 2024
@meteyou meteyou merged commit 2038258 into mainsail-crew:develop Nov 24, 2024
12 checks passed
@meteyou meteyou deleted the feat/change-tab-text-to-icons-status-panel branch November 24, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants