Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Webcam): add ICE check to support older CS versions #2069

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Dec 7, 2024

Description

This PR adds a check for ICE Candidates to fix the connection to older camera-streamer backends (for example the default version for the latest MainsailOS v1.3.2).

Related Tickets & Documents

fixes #2068

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

…r versions

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from rackrick and mryel00 December 7, 2024 14:20
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 7, 2024
@meteyou meteyou merged commit 7c23d9e into mainsail-crew:develop Dec 7, 2024
10 checks passed
@meteyou meteyou deleted the fix/fix-older-cs-versions branch December 7, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera-Streamer WebRTC not working
2 participants